From: XinHong Zhu Date: Fri, 14 Feb 2014 08:01:28 +0000 (+0800) Subject: [SCSI] pm80xx: fix problem of pm8001_work_fn reseting incorrect phy device X-Git-Tag: firefly_0821_release~176^2~4190^2~44 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=aed97b8b8194e818a94cc5ce5662f19b8bdd8adc;p=firefly-linux-kernel-4.4.55.git [SCSI] pm80xx: fix problem of pm8001_work_fn reseting incorrect phy device If a phy device is removed, the device can get error of I/O and HBA maybe receieve IO_OPEN_CNX_ERROR_IT_NEXUS_LOSS of event which causes pm8001_work_fn to reset the phy device but in pm8001_task_exec we don't assign a value for the device field of the ccb and in other case a ccb used have device field set, when ccb is freed the field device of the ccb don't be set NULL.So there is possibility of getting another device reset in function mpi_ssp_completion. Signed-off-by: zhuxh Acked-by: Lindar Liu Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index ba3088c99bfa..8a44bc92bc78 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -434,6 +434,7 @@ static int pm8001_task_exec(struct sas_task *task, const int num, ccb->n_elem = n_elem; ccb->ccb_tag = tag; ccb->task = t; + ccb->device = pm8001_dev; switch (t->task_proto) { case SAS_PROTOCOL_SMP: rc = pm8001_task_prep_smp(pm8001_ha, ccb);