From: Dan Carpenter Date: Wed, 5 Mar 2014 08:43:19 +0000 (+0300) Subject: Staging: rtl8712: fix an error test in start_drv_threads() X-Git-Tag: firefly_0821_release~176^2~4193^2~706 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=b16aad354a51d2ecfc46c94b9a89fa363e19af9d;p=firefly-linux-kernel-4.4.55.git Staging: rtl8712: fix an error test in start_drv_threads() Testing for "if (IS_ERR(padapter->cmdThread) < 0)" doesn't make sense. The kthread_run() function returns error pointers on error pointers on error so it should just be "if (IS_ERR(padapter->cmdThread))". Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 37fe33005c02..6bd08213cb70 100644 --- a/drivers/staging/rtl8712/os_intfs.c +++ b/drivers/staging/rtl8712/os_intfs.c @@ -239,7 +239,7 @@ static u32 start_drv_threads(struct _adapter *padapter) { padapter->cmdThread = kthread_run(r8712_cmd_thread, padapter, "%s", padapter->pnetdev->name); - if (IS_ERR(padapter->cmdThread) < 0) + if (IS_ERR(padapter->cmdThread)) return _FAIL; return _SUCCESS; }