From: Lars-Peter Clausen Date: Wed, 16 Nov 2011 19:34:04 +0000 (+0100) Subject: regmap: Drop check whether a register is readable in regcache_read X-Git-Tag: firefly_0821_release~3680^2~3815^2~15 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=b44d48c1ccf70273a91b7d3a920b0b54c3cb314f;p=firefly-linux-kernel-4.4.55.git regmap: Drop check whether a register is readable in regcache_read One of the reasons for using a cache is to have a software shadow of a register which is writable but not readable. This allows us to do a read-modify-write operation on such a register. Currently regcache checks whether a register is readable when performing a cached read and returns an error if it is not. Drop this check, since it will prevent us from using the cache for registers where read-back is not possible. Signed-off-by: Lars-Peter Clausen Signed-off-by: Mark Brown --- diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 6d93e49c462f..e21eebd36afa 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -199,9 +199,6 @@ int regcache_read(struct regmap *map, BUG_ON(!map->cache_ops); - if (!regmap_readable(map, reg)) - return -EIO; - if (!regmap_volatile(map, reg)) return map->cache_ops->read(map, reg, value);