From: Eli Friedman Date: Tue, 14 Jul 2009 02:01:53 +0000 (+0000) Subject: Fix trivial todo in instcombine. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=b468709c917c27059100dc77e6c3b024bdfc3484;p=oota-llvm.git Fix trivial todo in instcombine. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@75586 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 838b33cb23c..864b2fa5ee0 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -2702,7 +2702,8 @@ Instruction *InstCombiner::visitMul(BinaryOperator &I) { Context->getConstantInt(Op0->getType(), Val.logBase2())); } } else if (isa(Op1->getType())) { - // TODO: If Op1 is all zeros and Op0 is all finite, return all zeros. + if (Op1->isNullValue()) + return ReplaceInstUsesWith(I, Op1); if (ConstantVector *Op1V = dyn_cast(Op1)) { if (Op1V->isAllOnesValue()) // X * -1 == 0 - X diff --git a/test/Transforms/InstCombine/mul.ll b/test/Transforms/InstCombine/mul.ll index 9b5f7a5c5ef..cd13803d310 100644 --- a/test/Transforms/InstCombine/mul.ll +++ b/test/Transforms/InstCombine/mul.ll @@ -83,3 +83,8 @@ define internal void @test13(<4 x float>*) { store <4 x float> %3, <4 x float>* %0, align 1 ret void } + +define <16 x i8> @test14(<16 x i8> %a) { + %b = mul <16 x i8> %a, zeroinitializer + ret <16 x i8> %b +}