From: Nicholas Ormrod <njormrod@fb.com>
Date: Wed, 16 Oct 2013 00:02:24 +0000 (-0700)
Subject: Change FBString's #define throw
X-Git-Tag: v0.22.0~815
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=b604632b63336e331f51ec7aa323c7377da51896;p=folly.git

Change FBString's #define throw

Summary:
Instead of defining throw to nothing, define it to something
which creates a grepable error message (re @tudorb in D1005889).

@override-unit-failures

Test Plan:
fbconfig -r folly
fbmake dbg && fbmake runtests && fbmake opt && fbmake runtests_opt

All tests passing.

Added throw to a few places in FBString; noticed that error messages
were produced, and that they contained the defined text. Those changes
not committed.

Reviewed By: tudorb@fb.com

FB internal diff: D1011963
---

diff --git a/folly/FBString.h b/folly/FBString.h
index f1da428d..541baa0f 100644
--- a/folly/FBString.h
+++ b/folly/FBString.h
@@ -107,7 +107,7 @@
 
 // FBString cannot use throw when replacing std::string, though it may still
 // use std::__throw_*
-#define throw
+#define throw FOLLY_FBSTRING_MAY_NOT_USE_THROW
 
 #ifdef _LIBSTDCXX_FBSTRING
 namespace std _GLIBCXX_VISIBILITY(default) {