From: Wei Yongjun Date: Fri, 21 Sep 2012 05:57:31 +0000 (+0800) Subject: sbp-target: fix return value check in sbp_register_configfs() X-Git-Tag: firefly_0821_release~3680^2~1865^2~21 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=b659f4b4ff52b14dcef4848e3f434b3582842960;p=firefly-linux-kernel-4.4.55.git sbp-target: fix return value check in sbp_register_configfs() In case of error, the function target_fabric_configfs_init() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c index 0ce44cd3488e..0d6d7c1f025e 100644 --- a/drivers/target/sbp/sbp_target.c +++ b/drivers/target/sbp/sbp_target.c @@ -2543,9 +2543,9 @@ static int sbp_register_configfs(void) int ret; fabric = target_fabric_configfs_init(THIS_MODULE, "sbp"); - if (!fabric) { + if (IS_ERR(fabric)) { pr_err("target_fabric_configfs_init() failed\n"); - return -ENOMEM; + return PTR_ERR(fabric); } fabric->tf_ops = sbp_ops;