From: Matt Fleming Date: Tue, 14 Feb 2012 11:40:55 +0000 (+0000) Subject: OpenRISC: No need to reset handler if SA_ONESHOT X-Git-Tag: firefly_0821_release~3680^2~3267^2~10 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=b675eeb743abaa0b99a35c1fd32fea8e13a17d32;p=firefly-linux-kernel-4.4.55.git OpenRISC: No need to reset handler if SA_ONESHOT get_signal_to_deliver() already resets the signal handler if SA_ONESHOT is set in ka->sa.sa_flags, there's no need to do it again in handle_signal(). Furthermore, because we were modifying ka->sa.sa_handler (which is a copy of sighand->action[]) instead of sighand->action[] the original code actually had no effect on signal delivery. Acked-by: Oleg Nesterov Cc: Jonas Bonn Cc: Arnd Bergmann Cc: linux@lists.openrisc.net Signed-off-by: Matt Fleming Signed-off-by: Jonas Bonn --- diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c index 53741ba0210e..92d2218fcb97 100644 --- a/arch/openrisc/kernel/signal.c +++ b/arch/openrisc/kernel/signal.c @@ -260,9 +260,6 @@ handle_signal(unsigned long sig, { setup_rt_frame(sig, ka, info, oldset, regs); - if (ka->sa.sa_flags & SA_ONESHOT) - ka->sa.sa_handler = SIG_DFL; - spin_lock_irq(¤t->sighand->siglock); sigorsets(¤t->blocked, ¤t->blocked, &ka->sa.sa_mask); if (!(ka->sa.sa_flags & SA_NODEFER))