From: Jesper Juhl <jj@chaosbits.net>
Date: Sun, 6 Feb 2011 20:49:02 +0000 (-0300)
Subject: [media] TTUSB DVB: ttusb_boot_dsp() needs to release_firmware() or it leaks memory
X-Git-Tag: firefly_0821_release~7613^2~1709^2~248
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ba0fd56a4fbb92999554a2e417924796c2ad2f8f;p=firefly-linux-kernel-4.4.55.git

[media] TTUSB DVB: ttusb_boot_dsp() needs to release_firmware() or it leaks memory

In drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c:ttusb_boot_dsp() we
need to call release_firmware(fw) before returning or we'll leak - no
matter if we succeed or fail.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c b/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c
index 40625b26ac10..cbe2f0de1442 100644
--- a/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c
+++ b/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c
@@ -334,6 +334,7 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
 	err = ttusb_cmd(ttusb, b, 4, 0);
 
       done:
+	release_firmware(fw);
 	if (err) {
 		dprintk("%s: usb_bulk_msg() failed, return value %i!\n",
 			__func__, err);