From: Paul E. McKenney Date: Wed, 12 Feb 2014 19:54:32 +0000 (-0800) Subject: staging: Additional item for rtl8188eu TODO list X-Git-Tag: firefly_0821_release~176^2~4193^2~1119 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bacb6de62cce0af3be40248c89f980b604b8a54f;p=firefly-linux-kernel-4.4.55.git staging: Additional item for rtl8188eu TODO list The rtw_recv_indicatepkt() function in the file named drivers/staging/rtl8188eu/os_dep/recv_linux.c has this strange code: rcu_read_lock(); rcu_dereference(padapter->pnetdev->rx_handler_data); rcu_read_unlock(); This code has no effect. Normally, you would assign the result of rcu_dereference() to some variable, but it is not clear from the code what variable that would be. Therefore, this patch applies to the TODO file instead of the code itself. Signed-off-by: Paul E. McKenney Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8188eu/TODO b/drivers/staging/rtl8188eu/TODO index f7f389c40e71..b574b235b340 100644 --- a/drivers/staging/rtl8188eu/TODO +++ b/drivers/staging/rtl8188eu/TODO @@ -9,6 +9,11 @@ TODO: - merge Realtek's bugfixes and new features into the driver - switch to use LIB80211 - switch to use MAC80211 +- figure out what to do with this code in rtw_recv_indicatepkt(): + rcu_read_lock(); + rcu_dereference(padapter->pnetdev->rx_handler_data); + rcu_read_unlock(); + Perhaps delete it, perhaps assign to some local variable. Please send any patches to Greg Kroah-Hartman , and Larry Finger .