From: H Hartley Sweeten Date: Tue, 11 Sep 2012 22:08:06 +0000 (-0700) Subject: staging: comedi: adv_pci1710: remove board attach noise X-Git-Tag: firefly_0821_release~3680^2~1977^2~305 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bc4b4aa5f5153d42d03244c2cbb19546f6200aef;p=firefly-linux-kernel-4.4.55.git staging: comedi: adv_pci1710: remove board attach noise Remove the kernel message noise during the attach of the board. Use a simple/clean dev_info at the end of the attach. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/drivers/staging/comedi/drivers/adv_pci1710.c index 699f267004ad..e589684415ee 100644 --- a/drivers/staging/comedi/drivers/adv_pci1710.c +++ b/drivers/staging/comedi/drivers/adv_pci1710.c @@ -1332,8 +1332,6 @@ static int pci1710_attach(struct comedi_device *dev, int ret, subdev, n_subdevices; unsigned int irq; - dev_info(dev->class_dev, DRV_NAME ": attach\n"); - ret = alloc_private(dev, sizeof(*devpriv)); if (ret < 0) return -ENOMEM; @@ -1377,15 +1375,8 @@ static int pci1710_attach(struct comedi_device *dev, if (request_irq(irq, interrupt_service_pci1710, IRQF_SHARED, "Advantech PCI-1710", dev)) { - dev_dbg(dev->class_dev, - "unable to allocate IRQ %d, DISABLING IT", - irq); irq = 0; /* Can't use IRQ */ - } else { - dev_dbg(dev->class_dev, "irq=%u", irq); } - } else { - dev_dbg(dev->class_dev, "IRQ disabled"); } } else { irq = 0; @@ -1480,6 +1471,9 @@ static int pci1710_attach(struct comedi_device *dev, devpriv->valid = 1; + dev_info(dev->class_dev, "%s attached, irq %sabled\n", + dev->board_name, dev->irq ? "en" : "dis"); + return 0; }