From: Dan Gohman Date: Thu, 11 Sep 2008 18:53:02 +0000 (+0000) Subject: Fix a copy+paste bug that Duncan spotted. For several X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bcb37fd22f0345bdfd30c57e8a7f22fc6080e20a;p=oota-llvm.git Fix a copy+paste bug that Duncan spotted. For several cases it was still getting lucky and detecting overflow but it was clearly incorrect. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@56113 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 46ac762b0a7..5a9d1de2e35 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -4699,7 +4699,7 @@ static bool AddWithOverflow(ConstantInt *&Result, ConstantInt *In1, /// overflowed for this type. static bool SubWithOverflow(ConstantInt *&Result, ConstantInt *In1, ConstantInt *In2, bool IsSigned = false) { - Result = cast(Add(In1, In2)); + Result = cast(Subtract(In1, In2)); if (IsSigned) if (In2->getValue().isNegative())