From: K. Y. Srinivasan <kys@microsoft.com>
Date: Wed, 27 Aug 2014 23:25:35 +0000 (-0700)
Subject: Drivers: hv: vmbus: Fix a bug in vmbus_open()
X-Git-Tag: firefly_0821_release~3679^2~1352
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bd6174827fa6862fc2b59c2e0eeee5e5329befa2;p=firefly-linux-kernel-4.4.55.git

Drivers: hv: vmbus: Fix a bug in vmbus_open()

commit 45d727cee9e200f5b351528b9fb063b69cf702c8 upstream.

Fix a bug in vmbus_open() and properly propagate the error. I would
like to thank Dexuan Cui <decui@microsoft.com> for identifying the
issue.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Tested-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index d34db9fdc518..92f34de7aee9 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -199,8 +199,10 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size,
 	ret = vmbus_post_msg(open_msg,
 			       sizeof(struct vmbus_channel_open_channel));
 
-	if (ret != 0)
+	if (ret != 0) {
+		err = ret;
 		goto error1;
+	}
 
 	t = wait_for_completion_timeout(&open_info->waitevent, 5*HZ);
 	if (t == 0) {