From: Krzysztof Halasa Date: Thu, 10 Jun 2010 23:08:20 +0000 (+0200) Subject: kbuild: Fix modpost segfault X-Git-Tag: firefly_0821_release~10186^2~1274 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bf1fe0bc49306efd7b822d1a90bfafbd4cb68694;p=firefly-linux-kernel-4.4.55.git kbuild: Fix modpost segfault commit 1c938663d58b5b2965976a6f54cc51b5d6f691aa upstream. Alan writes: > program: /home/alan/GitTrees/linux-2.6-mid-ref/scripts/mod/modpost -o > Module.symvers -S vmlinux.o > > Program received signal SIGSEGV, Segmentation fault. It just hit me. It's the offset calculation in reloc_location() which overflows: return (void *)elf->hdr + sechdrs[section].sh_offset + (r->r_offset - sechdrs[section].sh_addr); E.g. for the first rodata r entry: r->r_offset < sechdrs[section].sh_addr and the expression in the parenthesis produces 0xFFFFFFE0 or something equally wise. Reported-by: Alan Signed-off-by: Krzysztof Hałasa Tested-by: Alan Signed-off-by: Michal Marek Signed-off-by: Greg Kroah-Hartman --- diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 801a16a17545..03efeabdfdb9 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1311,7 +1311,7 @@ static unsigned int *reloc_location(struct elf_info *elf, int section = sechdr->sh_info; return (void *)elf->hdr + sechdrs[section].sh_offset + - (r->r_offset - sechdrs[section].sh_addr); + r->r_offset - sechdrs[section].sh_addr; } static int addend_386_rel(struct elf_info *elf, Elf_Shdr *sechdr, Elf_Rela *r)