From: Benoit Taine Date: Mon, 19 May 2014 16:24:26 +0000 (+0200) Subject: staging: rts5208: Use pci_device_id rather than DEFINE_PCI_DEVICE_TABLE X-Git-Tag: firefly_0821_release~176^2~3465^2~39^2~347 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bf5269574013772050a91ace0a137d33f1f4e4d5;p=firefly-linux-kernel-4.4.55.git staging: rts5208: Use pci_device_id rather than DEFINE_PCI_DEVICE_TABLE This patch enhances kernel style usage for the rts5208 driver. We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. Signed-off-by: Benoit Taine Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index d2d1345fb06c..c0a0e6010372 100644 --- a/drivers/staging/rts5208/rtsx.c +++ b/drivers/staging/rts5208/rtsx.c @@ -1030,7 +1030,7 @@ static void rtsx_remove(struct pci_dev *pci) } /* PCI IDs */ -static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = { +static const struct pci_device_id rtsx_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5208), PCI_CLASS_OTHERS << 16, 0xFF0000 }, { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5288),