From: Rafael Espindola Date: Wed, 22 Dec 2010 19:05:49 +0000 (+0000) Subject: Revert r122359 while I debug PR8845. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bf57b838b8548ae581739cdc3dfbf4e23beb45df;p=oota-llvm.git Revert r122359 while I debug PR8845. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122427 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/MC/MCExpr.cpp b/lib/MC/MCExpr.cpp index 58f2e94dd62..8fdf8378333 100644 --- a/lib/MC/MCExpr.cpp +++ b/lib/MC/MCExpr.cpp @@ -269,13 +269,27 @@ bool MCExpr::EvaluateAsAbsolute(int64_t &Res, const MCAssembler *Asm, // FIXME: The use if InSet = Addrs is a hack. Setting InSet causes us // absolutize differences across sections and that is what the MachO writer // uses Addrs for. - bool IsRelocatable = - EvaluateAsRelocatableImpl(Value, Asm, Layout, Addrs, /*InSet*/ Addrs); + if (!EvaluateAsRelocatableImpl(Value, Asm, Layout, Addrs, /*InSet*/ Addrs) || + !Value.isAbsolute()) { + // EvaluateAsAbsolute is defined to return the "current value" of + // the expression if we are given a Layout object, even in cases + // when the value is not fixed. + if (Layout) { + Res = Value.getConstant(); + if (Value.getSymA()) { + Res += Layout->getSymbolOffset( + &Layout->getAssembler().getSymbolData(Value.getSymA()->getSymbol())); + } + if (Value.getSymB()) { + Res -= Layout->getSymbolOffset( + &Layout->getAssembler().getSymbolData(Value.getSymB()->getSymbol())); + } + } + return false; + } - // Record the current value. Res = Value.getConstant(); - - return IsRelocatable && Value.isAbsolute(); + return true; } /// \brief Helper method for \see EvaluateSymbolAdd().