From: Dan Rosenberg Date: Thu, 30 Sep 2010 22:15:31 +0000 (-0700) Subject: sys_semctl: fix kernel stack leakage X-Git-Tag: firefly_0821_release~10186^2~717 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bf8dfc64f69b0160a915b5dbd2c39054ce295643;p=firefly-linux-kernel-4.4.55.git sys_semctl: fix kernel stack leakage commit 982f7c2b2e6a28f8f266e075d92e19c0dd4c6e56 upstream. The semctl syscall has several code paths that lead to the leakage of uninitialized kernel stack memory (namely the IPC_INFO, SEM_INFO, IPC_STAT, and SEM_STAT commands) during the use of the older, obsolete version of the semid_ds struct. The copy_semid_to_user() function declares a semid_ds struct on the stack and copies it back to the user without initializing or zeroing the "sem_base", "sem_pending", "sem_pending_last", and "undo" pointers, allowing the leakage of 16 bytes of kernel stack memory. The code is still reachable on 32-bit systems - when calling semctl() newer glibc's automatically OR the IPC command with the IPC_64 flag, but invoking the syscall directly allows users to use the older versions of the struct. Signed-off-by: Dan Rosenberg Cc: Manfred Spraul Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- diff --git a/ipc/sem.c b/ipc/sem.c index 2f2a47959576..b781007eea46 100644 --- a/ipc/sem.c +++ b/ipc/sem.c @@ -560,6 +560,8 @@ static unsigned long copy_semid_to_user(void __user *buf, struct semid64_ds *in, { struct semid_ds out; + memset(&out, 0, sizeof(out)); + ipc64_perm_to_ipc_perm(&in->sem_perm, &out.sem_perm); out.sem_otime = in->sem_otime;