From: Colin Ian King Date: Sat, 17 May 2014 22:33:44 +0000 (+0100) Subject: IB/mlx4: fix unitialised variable is_mcast X-Git-Tag: firefly_0821_release~176^2~3797^2^7~7 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=bfdfcfee3c9281e9cd28c0b08235aba1762504a6;p=firefly-linux-kernel-4.4.55.git IB/mlx4: fix unitialised variable is_mcast Commit 297e0dad7206 ("IB/mlx4: Handle Ethernet L2 parameters for IP based GID addressing") introduced a bug where is_mcast is now no longer initialized on the non-multicast condition and so it can be any random value from the stack. This issue was detected by cppcheck: [drivers/infiniband/hw/mlx4/ah.c:103]: (error) Uninitialized variable: is_mcast Simple fix is to initialise is_mcast to zero. Signed-off-by: Colin Ian King Signed-off-by: Roland Dreier --- diff --git a/drivers/infiniband/hw/mlx4/ah.c b/drivers/infiniband/hw/mlx4/ah.c index 170dca608042..2d8c3397774f 100644 --- a/drivers/infiniband/hw/mlx4/ah.c +++ b/drivers/infiniband/hw/mlx4/ah.c @@ -73,7 +73,7 @@ static struct ib_ah *create_iboe_ah(struct ib_pd *pd, struct ib_ah_attr *ah_attr { struct mlx4_ib_dev *ibdev = to_mdev(pd->device); struct mlx4_dev *dev = ibdev->dev; - int is_mcast; + int is_mcast = 0; struct in6_addr in6; u16 vlan_tag;