From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Wed, 12 Feb 2014 23:10:28 +0000 (-0600)
Subject: staging: rtl8821ae: Fix potential infinite loop
X-Git-Tag: firefly_0821_release~176^2~4193^2~1121
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c3eaaf8b5b01cf076525e23d26269027a8cfe8a6;p=firefly-linux-kernel-4.4.55.git

staging: rtl8821ae: Fix potential infinite loop

Smatch reports the following:
drivers/staging/rtl8821ae/rtl8821ae/hw.c:153 _rtl8821ae_set_fw_clock_on() info: ignoring unreachable code.

Upon investigation, the code in this region has the capability of creating
an infinite loop.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c b/drivers/staging/rtl8821ae/rtl8821ae/hw.c
index 5ed7a114c56b..e8344be92344 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hw.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hw.c
@@ -147,6 +147,7 @@ static void _rtl8821ae_set_fw_clock_on(struct ieee80211_hw *hw,
 		} else {
 			rtlhal->bfw_clk_change_in_progress = false;
 			spin_unlock_bh(&rtlpriv->locks.fw_ps_lock);
+			break;
 		}
 	}