From: Erik Verbruggen Date: Tue, 25 Mar 2014 09:06:18 +0000 (+0000) Subject: Simplify loop that worked around bugs in old GCC/Xcode. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c5f5d0d234ab571014798c23590dfb60526f6ac8;p=oota-llvm.git Simplify loop that worked around bugs in old GCC/Xcode. GCC 4.0.1 and Xcode 2 are no longer supported for building llvm/clang. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204705 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/CFG.cpp b/lib/Analysis/CFG.cpp index 9ebbb678497..69637606328 100644 --- a/lib/Analysis/CFG.cpp +++ b/lib/Analysis/CFG.cpp @@ -101,15 +101,9 @@ bool llvm::isCriticalEdge(const TerminatorInst *TI, unsigned SuccNum, // If AllowIdenticalEdges is true, then we allow this edge to be considered // non-critical iff all preds come from TI's block. - while (I != E) { - const BasicBlock *P = *I; - if (P != FirstPred) + for (; I != E; ++I) + if (*I != FirstPred) return true; - // Note: leave this as is until no one ever compiles with either gcc 4.0.1 - // or Xcode 2. This seems to work around the pred_iterator assert in PR 2207 - E = pred_end(P); - ++I; - } return false; }