From: Benjamin Romer Date: Fri, 5 Dec 2014 22:08:45 +0000 (-0500) Subject: staging: unisys: fix strict checks in create_device() X-Git-Tag: firefly_0821_release~176^2~2320^2~540 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c62bddfb6aea7e2fa5ba85f83f71e17e8e681e55;p=firefly-linux-kernel-4.4.55.git staging: unisys: fix strict checks in create_device() Use the variable name rather than the type, and add a set of missing brackets to the if statement in create_device(). Signed-off-by: Ken Depro Signed-off-by: Benjamin Romer Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/staging/unisys/uislib/uislib.c index 1ddbe78999ae..8a48091f993e 100644 --- a/drivers/staging/unisys/uislib/uislib.c +++ b/drivers/staging/unisys/uislib/uislib.c @@ -361,7 +361,7 @@ create_device(struct controlvm_message *msg, char *buf) POSTCODE_LINUX_4(DEVICE_CREATE_ENTRY_PC, devNo, busNo, POSTCODE_SEVERITY_INFO); - dev = kzalloc(sizeof(struct device_info), GFP_ATOMIC); + dev = kzalloc(sizeof(*dev), GFP_ATOMIC); if (!dev) { LOGERR("CONTROLVM_DEVICE_CREATE Failed: kmalloc for dev failed.\n"); POSTCODE_LINUX_4(DEVICE_CREATE_FAILURE_PC, devNo, busNo, @@ -377,9 +377,9 @@ create_device(struct controlvm_message *msg, char *buf) sema_init(&dev->interrupt_callback_lock, 1); /* unlocked */ sprintf(dev->devid, "vbus%u:dev%u", (unsigned)busNo, (unsigned)devNo); /* map the channel memory for the device. */ - if (msg->hdr.flags.test_message) + if (msg->hdr.flags.test_message) { dev->chanptr = (void __iomem *)__va(dev->channel_addr); - else { + } else { pReqHandler = req_handler_find(dev->channel_uuid); if (pReqHandler) /* generic service handler registered for this