From: vcdt34 <john.poplett@motorola.com>
Date: Wed, 29 Sep 2010 21:37:53 +0000 (-0500)
Subject: [ARM] tegra: stingray: Invalid kfree in lm3559 error path
X-Git-Tag: firefly_0821_release~9834^2~510
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c7c0790dce81938e807bc04c9a25168744a6a201;p=firefly-linux-kernel-4.4.55.git

[ARM] tegra: stingray: Invalid kfree in lm3559 error path

A failed write in the lm3559 driver takes an error path
that incorrectly attempted to free statically allocated
memory, resulting in a kernel crash. This bug prevents
the kernel from booting successfully on development
hardware systems that doesn't have the torch LED.

Change-Id: I96d252c5d5b6939f5d47e27aece81e1f61ba1cd1
Signed-off-by: John Poplett <john.poplett@motorola.com>
---

diff --git a/drivers/leds/led-lm3559.c b/drivers/leds/led-lm3559.c
index 7434eac89a0a..2b8bb805efe8 100644
--- a/drivers/leds/led-lm3559.c
+++ b/drivers/leds/led-lm3559.c
@@ -404,7 +404,6 @@ static int lm3559_remove(struct i2c_client *client)
 			led_classdev_unregister(&torch_data->flash_dev);
 		}
 
-		kfree(torch_data->pdata);
 		kfree(torch_data);
 	}
 	return 0;