From: Archit Taneja Date: Wed, 7 Nov 2012 09:17:24 +0000 (+0530) Subject: OMAPDSS: APPLY: Remove unnecessary call to mg_clear_shadow_dirty X-Git-Tag: firefly_0821_release~3680^2~1437^2^2~42 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c90929020986d12577570139ed6b787367823ade;p=firefly-linux-kernel-4.4.55.git OMAPDSS: APPLY: Remove unnecessary call to mg_clear_shadow_dirty When doing a manual update in dss_mgr_start_update, we clear the shadow dirty flags. Although there isn't any harm in clearing them. The need to clear them out here should never arrive. When applying configurations for a manual update manager, we never do any register writes, i.e, calls to dss_mgr_write_regs and dss_mgr_write_regs_extra never happen while applying. We do all these writes only when we call dss_mgr_start_update. Hence, there is never a time when the shadow registers are dirty. Remove the call to mg_clear_shadow_dirty. Signed-off-by: Archit Taneja Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c index 55fb5d778ae5..4a5cc5c64d4b 100644 --- a/drivers/video/omap2/dss/apply.c +++ b/drivers/video/omap2/dss/apply.c @@ -770,8 +770,6 @@ void dss_mgr_start_update(struct omap_overlay_manager *mgr) dispc_mgr_enable_sync(mgr->id); - mgr_clear_shadow_dirty(mgr); - spin_unlock_irqrestore(&data_lock, flags); }