From: Jesper Juhl Date: Mon, 9 Apr 2012 20:50:47 +0000 (+0200) Subject: wireless, at76c50x:: Don't needlessly test for NULL before calling release_firmware() X-Git-Tag: firefly_0821_release~3680^2~2787^2~410^2~124 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c987ce93ad7f96ca637d1f866ff22cfcbfe99d47;p=firefly-linux-kernel-4.4.55.git wireless, at76c50x:: Don't needlessly test for NULL before calling release_firmware() The release_firmware() function deals gracefully with being passed a NULL pointer, so explicit tests before the call are rather pointless. Signed-off-by: Jesper Juhl Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c index 4045e5ab0555..faa8bcb4aac1 100644 --- a/drivers/net/wireless/at76c50x-usb.c +++ b/drivers/net/wireless/at76c50x-usb.c @@ -2512,10 +2512,8 @@ static void __exit at76_mod_exit(void) printk(KERN_INFO DRIVER_DESC " " DRIVER_VERSION " unloading\n"); usb_deregister(&at76_driver); - for (i = 0; i < ARRAY_SIZE(firmwares); i++) { - if (firmwares[i].fw) - release_firmware(firmwares[i].fw); - } + for (i = 0; i < ARRAY_SIZE(firmwares); i++) + release_firmware(firmwares[i].fw); led_trigger_unregister_simple(ledtrig_tx); }