From: Yedidya Feldblum <yfeldblum@fb.com>
Date: Wed, 7 Dec 2016 22:14:47 +0000 (-0800)
Subject: Cut some includes from Executor.h
X-Git-Tag: v2016.12.12.00~10
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=c9fc2e3200eaa8fde46f7a31447d278325bebd3b;p=folly.git

Cut some includes from Executor.h

Summary: [Folly] Cut some includes from `Executor.h`.

Reviewed By: mzlee

Differential Revision: D4256618

fbshipit-source-id: 1728f48b3c0ec4e0c4c84c44bd8afb583d438129
---

diff --git a/folly/Executor.cpp b/folly/Executor.cpp
new file mode 100644
index 00000000..c1ec002d
--- /dev/null
+++ b/folly/Executor.cpp
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2016 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <folly/Executor.h>
+
+#include <stdexcept>
+
+namespace folly {
+
+void Executor::addWithPriority(Func, int8_t /* priority */) {
+  throw std::runtime_error(
+      "addWithPriority() is not implemented for this Executor");
+}
+}
diff --git a/folly/Executor.h b/folly/Executor.h
index 89e684e6..68670faa 100644
--- a/folly/Executor.h
+++ b/folly/Executor.h
@@ -16,10 +16,7 @@
 
 #pragma once
 
-#include <atomic>
 #include <climits>
-#include <functional>
-#include <stdexcept>
 
 #include <folly/Function.h>
 
@@ -39,10 +36,7 @@ class Executor {
 
   /// Enqueue a function with a given priority, where 0 is the medium priority
   /// This is up to the implementation to enforce
-  virtual void addWithPriority(Func, int8_t /*priority*/) {
-    throw std::runtime_error(
-        "addWithPriority() is not implemented for this Executor");
-  }
+  virtual void addWithPriority(Func, int8_t priority);
 
   virtual uint8_t getNumPriorities() const {
     return 1;
diff --git a/folly/Makefile.am b/folly/Makefile.am
index 23346fd0..d797e082 100644
--- a/folly/Makefile.am
+++ b/folly/Makefile.am
@@ -413,6 +413,7 @@ libfolly_la_SOURCES = \
 	detail/IPAddress.cpp \
 	dynamic.cpp \
 	ExceptionWrapper.cpp \
+	Executor.cpp \
 	File.cpp \
 	FileUtil.cpp \
 	FingerprintTables.cpp \