From: Matthew Thode <mthode@mthode.org>
Date: Wed, 18 Feb 2015 00:31:57 +0000 (-0600)
Subject: net: reject creation of netdev names with colons
X-Git-Tag: firefly_0821_release~3679^2~741
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=cde81ed79fc1540a3c3e775515d72f441aef8e6c;p=firefly-linux-kernel-4.4.55.git

net: reject creation of netdev names with colons

[ Upstream commit a4176a9391868bfa87705bcd2e3b49e9b9dd2996 ]

colons are used as a separator in netdev device lookup in dev_ioctl.c

Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME

Signed-off-by: Matthew Thode <mthode@mthode.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/net/core/dev.c b/net/core/dev.c
index c310440309bb..aeca8dd88b2a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -927,7 +927,7 @@ bool dev_valid_name(const char *name)
 		return false;
 
 	while (*name) {
-		if (*name == '/' || isspace(*name))
+		if (*name == '/' || *name == ':' || isspace(*name))
 			return false;
 		name++;
 	}