From: Philipp Zabel <p.zabel@pengutronix.de>
Date: Tue, 4 Mar 2014 11:31:24 +0000 (+0100)
Subject: of: Warn if of_graph_parse_endpoint is called with the root node
X-Git-Tag: firefly_0821_release~176^2~4193^2~586^2~11^2~1
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d484700a36952c6675aa47dec4d7a536929aa922;p=firefly-linux-kernel-4.4.55.git

of: Warn if of_graph_parse_endpoint is called with the root node

If of_graph_parse_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 715144af3a83..fd4b9c2eaa15 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1996,6 +1996,9 @@ int of_graph_parse_endpoint(const struct device_node *node,
 {
 	struct device_node *port_node = of_get_parent(node);
 
+	WARN_ONCE(!port_node, "%s(): endpoint %s has no parent node\n",
+		  __func__, node->full_name);
+
 	memset(endpoint, 0, sizeof(*endpoint));
 
 	endpoint->local_node = node;