From: Frans Klaver Date: Wed, 17 Sep 2014 21:47:27 +0000 (+0200) Subject: eeepc-laptop: store_cpufv: return error if set_acpi fails X-Git-Tag: firefly_0821_release~176^2~3070^2~6 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d48690383febbf17d958e909ff8f0d15f4497325;p=firefly-linux-kernel-4.4.55.git eeepc-laptop: store_cpufv: return error if set_acpi fails The result of set_acpi is left unchecked, but it may return errors. If one occurs, send the error to the caller. There's no reason to lie about it, if set_acpi fails. Signed-off-by: Frans Klaver Signed-off-by: Darren Hart --- diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index 875a43fcaa86..3f6c762fb560 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c @@ -388,7 +388,9 @@ static ssize_t cpufv_store(struct device *dev, return rv; if (value < 0 || value >= c.num) return -EINVAL; - set_acpi(eeepc, CM_ASL_CPUFV, value); + rv = set_acpi(eeepc, CM_ASL_CPUFV, value); + if (rv) + return rv; return count; }