From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Wed, 19 Sep 2012 22:09:57 +0000 (-0700)
Subject: staging: comedi: s526: remove unneeded check in s526_gpct_rinsn()
X-Git-Tag: firefly_0821_release~3680^2~1977^2~76
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d52f042ce5d64bbc56160e3653de064d380120c7;p=firefly-linux-kernel-4.4.55.git

staging: comedi: s526: remove unneeded check in s526_gpct_rinsn()

The comedi core validates insn->n before calling this function.
Remove the unnecessary check.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/s526.c b/drivers/staging/comedi/drivers/s526.c
index 75e3e58e552a..f9f0fdaec159 100644
--- a/drivers/staging/comedi/drivers/s526.c
+++ b/drivers/staging/comedi/drivers/s526.c
@@ -217,11 +217,6 @@ static int s526_gpct_rinsn(struct comedi_device *dev,
 	unsigned short datalow;
 	unsigned short datahigh;
 
-	/*  Check if (n > 0) */
-	if (insn->n <= 0) {
-		printk(KERN_ERR "s526: INSN_READ: n should be > 0\n");
-		return -EINVAL;
-	}
 	/*  Read the low word first */
 	for (i = 0; i < insn->n; i++) {
 		datalow = inw(dev->iobase + REG_C0L + counter_channel * 8);