From: Chris Lattner Date: Mon, 18 Feb 2008 02:18:25 +0000 (+0000) Subject: simplify some code, BreakUpSubtract always returns nonnull now. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d5b8d92b9f4dfb216e4f2a52b4e801d7559574ba;p=oota-llvm.git simplify some code, BreakUpSubtract always returns nonnull now. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47251 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/Reassociate.cpp b/lib/Transforms/Scalar/Reassociate.cpp index 3e2d38f76ba..47c767feb63 100644 --- a/lib/Transforms/Scalar/Reassociate.cpp +++ b/lib/Transforms/Scalar/Reassociate.cpp @@ -779,10 +779,8 @@ void Reassociate::ReassociateBB(BasicBlock *BB) { // see if we can convert it to X+-Y. if (BI->getOpcode() == Instruction::Sub) { if (ShouldBreakUpSubtract(BI)) { - if (Instruction *NI = BreakUpSubtract(BI)) { - MadeChange = true; - BI = NI; - } + BI = BreakUpSubtract(BI); + MadeChange = true; } else if (BinaryOperator::isNeg(BI)) { // Otherwise, this is a negation. See if the operand is a multiply tree // and if this is not an inner node of a multiply tree.