From: H Hartley Sweeten <hsweeten@visionengravers.com>
Date: Thu, 17 Jul 2014 18:57:30 +0000 (-0700)
Subject: staging: comedi: pcl816: remove use of comedi_error()
X-Git-Tag: firefly_0821_release~176^2~3491^2~574
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d656a35652c76bd68dc5f6a94d96f6a9d436fb0a;p=firefly-linux-kernel-4.4.55.git

staging: comedi: pcl816: remove use of comedi_error()

The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.

Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index eda9986d9cf8..7cd54359af64 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -552,7 +552,7 @@ check_channel_list(struct comedi_device *dev,
 
 	/*  correct channel and range number check itself comedi/range.c */
 	if (chanlen < 1) {
-		comedi_error(dev, "range/channel list is empty!");
+		dev_err(dev->class_dev, "range/channel list is empty!\n");
 		return 0;
 	}