From: Andreas Ruprecht Date: Fri, 2 Dec 2011 16:30:23 +0000 (+0100) Subject: Staging: iio/accel: Added a range check for val in store_measurement_mode() X-Git-Tag: firefly_0821_release~3680^2~3804^2~101^2~96 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d666c0d490d85d35fe6d6d45ba029cf16046dc82;p=firefly-linux-kernel-4.4.55.git Staging: iio/accel: Added a range check for val in store_measurement_mode() In sca3000_store_measurement_mode() we use val to and it with a mask. This mask is only two bits long (as we are only interested in the lowest two bits), so a value bigger than 3 was silently ignored so far. Now this function will return -EINVAL, if val is bigger than 3. Signed-off-by: Andreas Ruprecht Acked-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index 12f1e4bc769c..a1277d2700ee 100644 --- a/drivers/staging/iio/accel/sca3000_core.c +++ b/drivers/staging/iio/accel/sca3000_core.c @@ -389,6 +389,10 @@ sca3000_store_measurement_mode(struct device *dev, ret = kstrtou8(buf, 10, &val); if (ret) goto error_ret; + if (val > 3) { + ret = -EINVAL; + goto error_ret; + } ret = sca3000_read_data_short(st, SCA3000_REG_ADDR_MODE, 1); if (ret) goto error_ret;