From: H Hartley Sweeten <hsweeten@visionengravers.com>
Date: Tue, 14 May 2013 21:35:47 +0000 (-0700)
Subject: staging: comedi: dt9812: default the analog input gain to 1
X-Git-Tag: firefly_0821_release~176^2~5845^2~604
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=d6caedf074afe10d585df6d8e61c7a171d91e44f;p=firefly-linux-kernel-4.4.55.git

staging: comedi: dt9812: default the analog input gain to 1

The 'default' case should never happen. In case it does, default the
gain to '1'.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c
index 9281d49dbdeb..e6d9191f9432 100644
--- a/drivers/staging/comedi/drivers/dt9812.c
+++ b/drivers/staging/comedi/drivers/dt9812.c
@@ -422,6 +422,8 @@ static void dt9812_configure_gain(struct comedi_device *dev,
 		rmw->or_value = F020_MASK_ADC0CF_AMP0GN2 |
 				F020_MASK_ADC0CF_AMP0GN1;
 		break;
+	default:
+		/* this should never happen, just use a gain of 1 */
 	case DT9812_GAIN_1:
 		rmw->or_value = 0x00;
 		break;
@@ -438,9 +440,6 @@ static void dt9812_configure_gain(struct comedi_device *dev,
 	case DT9812_GAIN_16:
 		rmw->or_value = F020_MASK_ADC0CF_AMP0GN2;
 		break;
-	default:
-		dev_err(dev->class_dev, "Illegal gain %d\n", gain);
-		break;
 	}
 }