From: Steven Rostedt (Red Hat) <rostedt@goodmis.org>
Date: Tue, 10 Jun 2014 17:53:50 +0000 (-0400)
Subject: tracing: Fix check of ftrace_trace_arrays list_empty() check
X-Git-Tag: firefly_0821_release~176^2~3758^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=da9c3413a27be5ba6f996e90495c836dd30b8841;p=firefly-linux-kernel-4.4.55.git

tracing: Fix check of ftrace_trace_arrays list_empty() check

The check that tests if ftrace_trace_arrays is empty in
top_trace_array(), uses the .prev pointer:

  if (list_empty(ftrace_trace_arrays.prev))

instead of testing the variable itself:

  if (list_empty(&ftrace_trace_arrays))

Although it is technically correct, it is awkward and confusing.
Use the proper method.

Link: http://lkml.kernel.org/r/87oay1bas8.fsf@sejong.aot.lge.com

Reported-by: Namhyung Kim <namhyung@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---

diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 9e82551dd566..9258f5a815db 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -252,7 +252,7 @@ static inline struct trace_array *top_trace_array(void)
 {
 	struct trace_array *tr;
 
-	if (list_empty(ftrace_trace_arrays.prev))
+	if (list_empty(&ftrace_trace_arrays))
 		return NULL;
 
 	tr = list_entry(ftrace_trace_arrays.prev,