From: Jonathan Cameron <jic23@kernel.org>
Date: Fri, 3 Jan 2014 22:02:00 +0000 (+0000)
Subject: iio:adc:vf610 ensure correct handing of interruption of wait for completion
X-Git-Tag: firefly_0821_release~176^2~4193^2~709^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=db8fa7311d1ce642134c53e175ca0ae35e021344;p=firefly-linux-kernel-4.4.55.git

iio:adc:vf610 ensure correct handing of interruption of wait for completion

Issue highlighted by smatch warning:

CHECK   drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero.

As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if
interrupted, ret must be signed.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Fugang Duan <B38611@freescale.com>
---

diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index 37f542e8233c..44799eb5930e 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,
 {
 	struct vf610_adc *info = iio_priv(indio_dev);
 	unsigned int hc_cfg;
-	unsigned long ret;
+	long ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW: