From: Ken O'Brien Date: Sun, 5 Jun 2011 17:24:32 +0000 (+0100) Subject: Staging: rtl8192e: Fixed numerous coding style issues X-Git-Tag: firefly_0821_release~3680^2~4924^2~504 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=dc6b15f32243a2a5ce1d4dabe0a13cfd1d76c0e0;p=firefly-linux-kernel-4.4.55.git Staging: rtl8192e: Fixed numerous coding style issues Coding style review: fixed all warnings, and all but three typedef errors. Signed-off-by: Ken O'Brien Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h index 106ebcfa7d7d..3785fdf7f92e 100644 --- a/drivers/staging/rtl8192e/dot11d.h +++ b/drivers/staging/rtl8192e/dot11d.h @@ -19,11 +19,11 @@ typedef enum _DOT11D_STATE { /** * struct _RT_DOT11D_INFO * @CountryIeLen: value greater than 0 if @CountryIeBuf contains - * valid country information element. + * valid country information element. * @chanell_map: holds channel values * 0 - invalid, * 1 - valid (active scan), - * 2 - valid (passive scan) + * 2 - valid (passive scan) * @CountryIeSrcAddr - Source AP of the country IE */ @@ -49,7 +49,7 @@ static inline void cpMacAddr(unsigned char *des, unsigned char *src) #define GET_DOT11D_INFO(__pIeeeDev) ((PRT_DOT11D_INFO) \ ((__pIeeeDev)->pDot11dInfo)) -#define IS_DOT11D_ENABLE(__pIeeeDev) GET_DOT11D_INFO(__pIeeeDev)->bEnabled +#define IS_DOT11D_ENABLE(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)->bEnabled) #define IS_COUNTRY_IE_VALID(__pIeeeDev) \ (GET_DOT11D_INFO(__pIeeeDev)->CountryIeLen > 0) @@ -66,9 +66,10 @@ static inline void cpMacAddr(unsigned char *des, unsigned char *src) (__Ie).Octet, (__Ie).Length))) #define CIE_WATCHDOG_TH 1 -#define GET_CIE_WATCHDOG(__pIeeeDev) GET_DOT11D_INFO(__pIeeeDev)->CountryIeWatchdog +#define GET_CIE_WATCHDOG(__pIeeeDev) (GET_DOT11D_INFO(__pIeeeDev)-> \ + CountryIeWatchdog) #define RESET_CIE_WATCHDOG(__pIeeeDev) GET_CIE_WATCHDOG(__pIeeeDev) = 0 -#define UPDATE_CIE_WATCHDOG(__pIeeeDev) ++GET_CIE_WATCHDOG(__pIeeeDev) +#define UPDATE_CIE_WATCHDOG(__pIeeeDev) (++GET_CIE_WATCHDOG(__pIeeeDev)) #define IS_DOT11D_STATE_DONE(__pIeeeDev) \ (GET_DOT11D_INFO(__pIeeeDev)->State == DOT11D_STATE_DONE)