From: Devang Patel <dpatel@apple.com>
Date: Wed, 20 Feb 2008 19:39:41 +0000 (+0000)
Subject: getresult does not support nested aggregates.
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=dd4d45337b80ce73926e7a9ffc3b668da6d008f0;p=oota-llvm.git

getresult does not support nested aggregates.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@47396 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/VMCore/Instructions.cpp b/lib/VMCore/Instructions.cpp
index c1e583375a2..4197f80c922 100644
--- a/lib/VMCore/Instructions.cpp
+++ b/lib/VMCore/Instructions.cpp
@@ -2719,10 +2719,21 @@ GetResultInst::GetResultInst(Value *Aggregate, unsigned Index,
 bool GetResultInst::isValidOperands(const Value *Aggregate, unsigned Index) {
   if (!Aggregate)
     return false;
-  if (const StructType *STy = dyn_cast<StructType>(Aggregate->getType())) 
-    if (Index < STy->getNumElements())
-      return true;
 
+  if (const StructType *STy = dyn_cast<StructType>(Aggregate->getType())) {
+    unsigned NumElements = STy->getNumElements();
+    if (Index >= NumElements)
+      return false;
+
+    // getresult aggregate value's element types are restricted to
+    // avoid nested aggregates.
+    for (unsigned i = 0; i < NumElements; ++i)
+      if (!STy->getElementType(i)->isFirstClassType())
+        return false;
+
+    // Otherwise, Aggregate is valid.
+    return true;
+  }
   return false;
 }