From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Fri, 8 Aug 2014 10:07:50 +0000 (+0200)
Subject: imx-drm: imx-drm-core: delete unneeded test before of_node_put
X-Git-Tag: firefly_0821_release~176^2~3121^2~1344
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ddf5a2c1cb62a2ce4e6d9104998df2d3eae8923e;p=firefly-linux-kernel-4.4.55.git

imx-drm: imx-drm-core: delete unneeded test before of_node_put

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c
index 6b22106534d8..1852300412b4 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -471,8 +471,7 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
 		crtc_mask |= mask;
 	}
 
-	if (ep)
-		of_node_put(ep);
+	of_node_put(ep);
 	if (i == 0)
 		return -ENOENT;