From: Uwe Kleine-König Date: Wed, 16 Sep 2015 07:16:51 +0000 (+0200) Subject: rtc: rtctest: enabling UIE for a chip that doesn't support it returns EINVAL X-Git-Tag: firefly_0821_release~176^2~741^2~21 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=e21a47ff4dcef8c5fb57758035b266299b184146;p=firefly-linux-kernel-4.4.55.git rtc: rtctest: enabling UIE for a chip that doesn't support it returns EINVAL Calling ioctl(..., RTC_UIE_ON, ...) without CONFIG_RTC_INTF_DEV_UIE_EMUL either ends in rtc_update_irq_enable if rtc->uie_unsupported is true or in __rtc_set_alarm in the if (!rtc->ops->set_alarm) branch. In both cases the return value is -EINVAL. So check for that one instead of ENOTTY. Signed-off-by: Uwe Kleine-König Signed-off-by: Alexandre Belloni --- diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c index d80ae852334d..624bce51b27d 100644 --- a/tools/testing/selftests/timers/rtctest.c +++ b/tools/testing/selftests/timers/rtctest.c @@ -61,7 +61,7 @@ int main(int argc, char **argv) /* Turn on update interrupts (one per second) */ retval = ioctl(fd, RTC_UIE_ON, 0); if (retval == -1) { - if (errno == ENOTTY) { + if (errno == EINVAL) { fprintf(stderr, "\n...Update IRQs not supported.\n"); goto test_READ;