From: Moritz Fischer <moritz.fischer@ettus.com>
Date: Thu, 29 Oct 2015 15:56:31 +0000 (-0700)
Subject: fpga: socfpga: Fix check of return value of devm_request_irq
X-Git-Tag: firefly_0821_release~176^2~800^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=e2d8680741edec84f843f783a7f4a44418b818d7;p=firefly-linux-kernel-4.4.55.git

fpga: socfpga: Fix check of return value of devm_request_irq

The return value should be checked for non-zero, instead
of checking it being IS_ERR_VALUE().

Acked-by: Alan Tull <atull@opensource.altera.com>
Reviewed-by: Josh Cartwright <joshc@eso.teric.us>
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
index 706b80d25266..27d2ff28132c 100644
--- a/drivers/fpga/socfpga.c
+++ b/drivers/fpga/socfpga.c
@@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev)
 
 	ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0,
 			       dev_name(dev), priv);
-	if (IS_ERR_VALUE(ret))
+	if (ret)
 		return ret;
 
 	return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager",