From: Dan Carpenter Date: Thu, 22 Apr 2010 10:05:35 +0000 (+0200) Subject: security: testing the wrong variable in create_by_name() X-Git-Tag: firefly_0821_release~10186^2~1638 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=e3a126e62222b90f6c9ec63cc30cf443210764f7;p=firefly-linux-kernel-4.4.55.git security: testing the wrong variable in create_by_name() commit b338cc8207eae46640a8d534738fda7b5e48511d upstream. There is a typo here. We should be testing "*dentry" instead of "dentry". If "*dentry" is an ERR_PTR, it gets dereferenced in either mkdir() or create() which would cause an OOPs. Signed-off-by: Dan Carpenter Signed-off-by: James Morris Signed-off-by: Greg Kroah-Hartman --- diff --git a/security/inode.c b/security/inode.c index f7496c6a022b..3d78d69a629b 100644 --- a/security/inode.c +++ b/security/inode.c @@ -168,13 +168,13 @@ static int create_by_name(const char *name, mode_t mode, mutex_lock(&parent->d_inode->i_mutex); *dentry = lookup_one_len(name, parent, strlen(name)); - if (!IS_ERR(dentry)) { + if (!IS_ERR(*dentry)) { if ((mode & S_IFMT) == S_IFDIR) error = mkdir(parent->d_inode, *dentry, mode); else error = create(parent->d_inode, *dentry, mode); } else - error = PTR_ERR(dentry); + error = PTR_ERR(*dentry); mutex_unlock(&parent->d_inode->i_mutex); return error;