From: H Hartley Sweeten Date: Tue, 3 Dec 2013 19:07:22 +0000 (-0700) Subject: staging: comedi: pcl812: remove unnecessary s->len_chanlist init X-Git-Tag: firefly_0821_release~176^2~4489^2~574 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=e5fc1a19255616e77ab538bfce16b3ef0836f4b2;p=firefly-linux-kernel-4.4.55.git staging: comedi: pcl812: remove unnecessary s->len_chanlist init The subdevice 'len_chanlist' member is only used with async command support. Remove the initialization of this member for the subdevices that do not support commands. The core will then correctly initialize it to the default value of '1'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c index e1e4cd139b63..aabadea58fd6 100644 --- a/drivers/staging/comedi/drivers/pcl812.c +++ b/drivers/staging/comedi/drivers/pcl812.c @@ -1305,7 +1305,6 @@ no_dma: s->subdev_flags = SDF_WRITABLE | SDF_GROUND; s->n_chan = board->n_aochan; s->maxdata = 0xfff; - s->len_chanlist = 1; s->range_table = board->rangelist_ao; s->insn_read = pcl812_ao_insn_read; s->insn_write = pcl812_ao_insn_write; @@ -1334,7 +1333,6 @@ no_dma: s->subdev_flags = SDF_READABLE; s->n_chan = board->n_dichan; s->maxdata = 1; - s->len_chanlist = board->n_dichan; s->range_table = &range_digital; s->insn_bits = pcl812_di_insn_bits; subdev++; @@ -1347,7 +1345,6 @@ no_dma: s->subdev_flags = SDF_WRITABLE; s->n_chan = board->n_dochan; s->maxdata = 1; - s->len_chanlist = board->n_dochan; s->range_table = &range_digital; s->insn_bits = pcl812_do_insn_bits; subdev++;