From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 12 Aug 2015 21:08:01 +0000 (+0300)
Subject: cosa: missing error code on failure in probe()
X-Git-Tag: firefly_0821_release~176^2~1284^2
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=e6d006938c9bda7ffd22af9d3e1257fd75941fb7;p=firefly-linux-kernel-4.4.55.git

cosa: missing error code on failure in probe()

If register_hdlc_device() fails, the current code returns 0 but we
should return an error code instead.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index 7193b7304fdd..848ea6a399f2 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -589,7 +589,8 @@ static int cosa_probe(int base, int irq, int dma)
 		chan->netdev->base_addr = chan->cosa->datareg;
 		chan->netdev->irq = chan->cosa->irq;
 		chan->netdev->dma = chan->cosa->dma;
-		if (register_hdlc_device(chan->netdev)) {
+		err = register_hdlc_device(chan->netdev);
+		if (err) {
 			netdev_warn(chan->netdev,
 				    "register_hdlc_device() failed\n");
 			free_netdev(chan->netdev);