From: Nick Lewycky Date: Tue, 15 Nov 2011 01:23:22 +0000 (+0000) Subject: Move WEAK marking to the declaration. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=e7c1aef2b824f29ea92b2b324975915fe2115fa4;p=oota-llvm.git Move WEAK marking to the declaration. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@144603 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/Support/Valgrind.h b/include/llvm/Support/Valgrind.h index 0ecd33b6dd1..9b8d277eccd 100644 --- a/include/llvm/Support/Valgrind.h +++ b/include/llvm/Support/Valgrind.h @@ -24,14 +24,12 @@ // tsan (Thread Sanitizer) is a valgrind-based tool that detects these exact // functions by name. extern "C" { -LLVM_ATTRIBUTE_NOINLINE void AnnotateHappensAfter(const char *file, int line, - const volatile void *cv); -LLVM_ATTRIBUTE_NOINLINE void AnnotateHappensBefore(const char *file, int line, - const volatile void *cv); -LLVM_ATTRIBUTE_NOINLINE void AnnotateIgnoreWritesBegin(const char *file, - int line); -LLVM_ATTRIBUTE_NOINLINE void AnnotateIgnoreWritesEnd(const char *file, - int line); +LLVM_ATTRIBUTE_WEAK void AnnotateHappensAfter(const char *file, int line, + const volatile void *cv); +LLVM_ATTRIBUTE_WEAK void AnnotateHappensBefore(const char *file, int line, + const volatile void *cv); +LLVM_ATTRIBUTE_WEAK void AnnotateIgnoreWritesBegin(const char *file, int line); +LLVM_ATTRIBUTE_WEAK void AnnotateIgnoreWritesEnd(const char *file, int line); } #endif diff --git a/lib/Support/Valgrind.cpp b/lib/Support/Valgrind.cpp index 46d93a26ef6..078d705183d 100644 --- a/lib/Support/Valgrind.cpp +++ b/lib/Support/Valgrind.cpp @@ -56,10 +56,10 @@ void llvm::sys::ValgrindDiscardTranslations(const void *Addr, size_t Len) { // These functions require no implementation, tsan just looks at the arguments // they're called with. extern "C" { -LLVM_ATTRIBUTE_WEAK void AnnotateHappensBefore(const char *file, int line, - const volatile void *cv) {} -LLVM_ATTRIBUTE_WEAK void AnnotateHappensAfter(const char *file, int line, - const volatile void *cv) {} -LLVM_ATTRIBUTE_WEAK void AnnotateIgnoreWritesBegin(const char *file, int line){} -LLVM_ATTRIBUTE_WEAK void AnnotateIgnoreWritesEnd(const char *file, int line) {} +void AnnotateHappensBefore(const char *file, int line, + const volatile void *cv) {} +void AnnotateHappensAfter(const char *file, int line, + const volatile void *cv) {} +void AnnotateIgnoreWritesBegin(const char *file, int line) {} +void AnnotateIgnoreWritesEnd(const char *file, int line) {} }