From: Hans Fugal Date: Tue, 7 Apr 2015 01:20:00 +0000 (-0700) Subject: GlobalExecutor.h include Executor.h and IOExecutor.h X-Git-Tag: v0.35.0~12 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ec1a66c587f7b3223f154233874bd6db8a9a118f;p=folly.git GlobalExecutor.h include Executor.h and IOExecutor.h Summary: We were forward-declaring `Executor` and `IOExecutor` for great compilation speed. However, this leaves users of this header to include at least one of those headers in their cpp file to actually use it, and that's kind of annoying. `Executor` and `IOExecutor` are not templated and are quite small, so it seems like the compilation speed benefit is minimal compared to the convenience factor, so this diff just includes the two headers. (Probably including `Executor.h` is redundant since `IOExecutor.h` probably includes it, but for completeness and explicitness, and in case `IOExecutor` also just forward-declares `Executor` now or in the future.) Test Plan: stuff still builds Reviewed By: davejwatson@fb.com Subscribers: fugalh, exa, folly-diffs@, jsedgwick, yfeldblum, chalfant FB internal diff: D1970179 Signature: t1:1970179:1428351076:e9c3700a868688035e7ff50486b8cead751d3c02 --- diff --git a/folly/wangle/concurrent/GlobalExecutor.h b/folly/wangle/concurrent/GlobalExecutor.h index 409f5167..fa7d06c6 100644 --- a/folly/wangle/concurrent/GlobalExecutor.h +++ b/folly/wangle/concurrent/GlobalExecutor.h @@ -18,9 +18,8 @@ #include -namespace folly { -class Executor; -} +#include +#include namespace folly { namespace wangle { @@ -33,12 +32,11 @@ std::shared_ptr getCPUExecutor(); // subsequent calls to getCPUExecutor(). Takes a non-owning (weak) reference. void setCPUExecutor(std::shared_ptr executor); -// IOExecutors differ from Executors in that they drive and provide access to -// one or more EventBases. -class IOExecutor; - // Retrieve the global IOExecutor. If there is none, a default // IOThreadPoolExecutor will be constructed and returned. +// +// IOExecutors differ from Executors in that they drive and provide access to +// one or more EventBases. std::shared_ptr getIOExecutor(); // Set an IOExecutor to be the global IOExecutor which will be returned by