From: Chris Lattner Date: Thu, 17 Mar 2005 05:25:34 +0000 (+0000) Subject: Do not create ridiculously huge DSNodes, as described in the comments. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ec3f5c4fd769057ef98f08e8a160e315a2f10a18;p=oota-llvm.git Do not create ridiculously huge DSNodes, as described in the comments. This speeds up the BU pass on 172.mgrid from 62.3 -> 0.1242s. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@20648 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/DataStructure/DataStructure.cpp b/lib/Analysis/DataStructure/DataStructure.cpp index 06ae9b046c6..8857664d515 100644 --- a/lib/Analysis/DataStructure/DataStructure.cpp +++ b/lib/Analysis/DataStructure/DataStructure.cpp @@ -382,13 +382,23 @@ bool DSNode::mergeTypeInfo(const Type *NewTy, unsigned Offset, // question.... assert(Offset == 0 && !isArray() && "Cannot have an offset into a void node!"); + + // If this node would have to have an unreasonable number of fields, just + // collapse it. This can occur for fortran common blocks, which have stupid + // things like { [100000000 x double], [1000000 x double] }. + unsigned NumFields = (NewTySize+DS::PointerSize-1) >> DS::PointerShift; + if (NumFields > 64) { + foldNodeCompletely(); + return true; + } + Ty = NewTy; NodeType &= ~Array; if (WillBeArray) NodeType |= Array; Size = NewTySize; // Calculate the number of outgoing links from this node. - Links.resize((Size+DS::PointerSize-1) >> DS::PointerShift); + Links.resize(NumFields); return false; } @@ -418,6 +428,16 @@ bool DSNode::mergeTypeInfo(const Type *NewTy, unsigned Offset, Ty = NewTy; NodeType &= ~Array; if (WillBeArray) NodeType |= Array; + + // If this node would have to have an unreasonable number of fields, just + // collapse it. This can occur for fortran common blocks, which have stupid + // things like { [100000000 x double], [1000000 x double] }. + unsigned NumFields = (NewTySize+DS::PointerSize-1) >> DS::PointerShift; + if (NumFields > 64) { + foldNodeCompletely(); + return true; + } + Size = NewTySize; // Must grow links to be the appropriate size...