From: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Date: Fri, 19 Apr 2013 01:04:46 +0000 (+0000)
Subject: Btrfs: fix error handling in btrfs_ioctl_send()
X-Git-Tag: firefly_0821_release~3680^2~310^2~28
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ecc7ada77b5cd1ac525db8f7d4d266e88af66cc7;p=firefly-linux-kernel-4.4.55.git

Btrfs: fix error handling in btrfs_ioctl_send()

fget() returns NULL if error. So, we should check NULL or not.

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 158b91984b60..2037fc0efab1 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -4612,8 +4612,8 @@ long btrfs_ioctl_send(struct file *mnt_file, void __user *arg_)
 	sctx->flags = arg->flags;
 
 	sctx->send_filp = fget(arg->send_fd);
-	if (IS_ERR(sctx->send_filp)) {
-		ret = PTR_ERR(sctx->send_filp);
+	if (!sctx->send_filp) {
+		ret = -EBADF;
 		goto out;
 	}