From: Jakob Stoklund Olesen Date: Wed, 1 Feb 2012 22:19:26 +0000 (+0000) Subject: Fix a bug in the TopoOrderRC comparison function. X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ee599209e613cbe11ca67e8d084d2fc37d679f61;p=oota-llvm.git Fix a bug in the TopoOrderRC comparison function. The final tie breaker comparison also needs to return +/-1, or 0. This is not a less() function. This could cause otherwise identical super-classes to be ordered unstably, depending on what the system qsort routine does with a bad compare function. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149549 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/utils/TableGen/CodeGenRegisters.cpp b/utils/TableGen/CodeGenRegisters.cpp index 7c6661742aa..1d06f3e5287 100644 --- a/utils/TableGen/CodeGenRegisters.cpp +++ b/utils/TableGen/CodeGenRegisters.cpp @@ -503,7 +503,7 @@ static int TopoOrderRC(const void *PA, const void *PB) { return 1; // Finally order by name as a tie breaker. - return A->getName() < B->getName(); + return StringRef(A->getName()).compare(B->getName()); } std::string CodeGenRegisterClass::getQualifiedName() const {