From: Peter Hurley Date: Tue, 29 Jan 2013 03:34:43 +0000 (-0500) Subject: staging/fwserial: add diagnostic for buffer overflow X-Git-Tag: firefly_0821_release~3680^2~1080^2~213 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ef34dd184d58824f1cde7402afa8ba2a957029d9;p=firefly-linux-kernel-4.4.55.git staging/fwserial: add diagnostic for buffer overflow Signed-off-by: Peter Hurley Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index 258ac35fb5af..fe9a68854452 100644 --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -577,8 +577,11 @@ static int fwtty_buffer_rx(struct fwtty_port *port, unsigned char *d, size_t n) struct buffered_rx *buf; size_t size = (n + sizeof(struct buffered_rx) + 0xFF) & ~0xFF; - if (port->buffered + n > HIGH_WATERMARK) + if (port->buffered + n > HIGH_WATERMARK) { + fwtty_err_ratelimited(port, "overflowed rx buffer: buffered: %d new: %ld wtrmk: %d", + port->buffered, n, HIGH_WATERMARK); return 0; + } buf = kmalloc(size, GFP_ATOMIC); if (!buf) return 0;