From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 10 Oct 2012 07:18:35 +0000 (+0300)
Subject: oprofile, x86: Fix wrapping bug in op_x86_get_ctrl()
X-Git-Tag: firefly_0821_release~7541^2~441
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=ef9fccff2f6108bd5128113d64d260d3f075eb16;p=firefly-linux-kernel-4.4.55.git

oprofile, x86: Fix wrapping bug in op_x86_get_ctrl()

commit 44009105081b51417f311f4c3be0061870b6b8ed upstream.

The "event" variable is a u16 so the shift will always wrap to zero
making the line a no-op.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
index 68894fdc034b..a00c588b69d4 100644
--- a/arch/x86/oprofile/nmi_int.c
+++ b/arch/x86/oprofile/nmi_int.c
@@ -55,7 +55,7 @@ u64 op_x86_get_ctrl(struct op_x86_model_spec const *model,
 	val |= counter_config->extra;
 	event &= model->event_mask ? model->event_mask : 0xFF;
 	val |= event & 0xFF;
-	val |= (event & 0x0F00) << 24;
+	val |= (u64)(event & 0x0F00) << 24;
 
 	return val;
 }