From: Roland Dreier Date: Tue, 14 Feb 2012 00:18:16 +0000 (-0800) Subject: target: Don't set WBUS16 or SYNC bits in INQUIRY response X-Git-Tag: firefly_0821_release~3680^2~3307^2~34 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=effc6cc8828257c32c37635e737f14fd6e19ecd7;p=firefly-linux-kernel-4.4.55.git target: Don't set WBUS16 or SYNC bits in INQUIRY response SPC-4 says about the WBUS16 and SYNC bits: The meanings of these fields are specific to SPI-5 (see 6.4.3). For SCSI transport protocols other than the SCSI Parallel Interface, these fields are reserved. We don't have a SPI fabric module, so we should never set these bits. (The comment was misleading, since it only mentioned Sync but the actual code set WBUS16 too). Signed-off-by: Roland Dreier Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c index af8ebbde45ea..4f65b258cc25 100644 --- a/drivers/target/target_core_cdb.c +++ b/drivers/target/target_core_cdb.c @@ -95,7 +95,7 @@ target_emulate_inquiry_std(struct se_cmd *cmd, char *buf) if (dev->se_sub_dev->t10_alua.alua_type == SPC3_ALUA_EMULATED) target_fill_alua_data(lun->lun_sep, buf); - buf[7] = 0x32; /* Sync=1 and CmdQue=1 */ + buf[7] = 0x2; /* CmdQue=1 */ snprintf(&buf[8], 8, "LIO-ORG"); snprintf(&buf[16], 16, "%s", dev->se_sub_dev->t10_wwn.model);